Read SONG note decay timing from JSON#13
Merged
fuzziqersoftware merged 2 commits intoJun 22, 2025
Conversation
Owner
|
Thanks for implementing this - the difference is indeed striking, and it sounds much better. |
fuzziqersoftware
merged commit Jun 22, 2025
b1ba7eb
into
fuzziqersoftware:master
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fuzziqersoftware/resource_dasm#85 adds support for writing the note decay data embedded in classic Mac SONG resources to JSON. This PR updates smssynth to read this data. There's also a commit in here that gets smssynth building with the latest phosg changes.
This was used extensively in the music of SimCity 2000, and the before/after is striking:
10008_MoogyCit_before.mp4
10008_MoogyCit_after.mp4
Let me know if there's anything about the implementation you'd like me to change, C++ isn't my forte and I just tried to minimize the blast radius of these changes.