Fix login authentication when principal is provided as email#84
Merged
fuzziecoder merged 1 commit intocodex/fix-remaining-issues-and-raise-prfrom Feb 25, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
3ac4719
into
codex/fix-remaining-issues-and-raise-pr
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
admin,viewer).Description
TokenRequestinbackend/api/security.pyto accept optionalusernameandemailfields and added aprincipalproperty to normalize the login principal._candidate_usernameshelper and changedauthenticate_userto accept aprincipaland try both the full normalized input and the local-part (before@) when matching the demo user store./api/auth/tokenroute inbackend/api/routes/auth.pyto validate that eitherusernameoremailwas provided and to call the updatedauthenticate_userwith the resolvedprincipal.Testing
authenticate_userwith both username and email forms which succeeded via:python - <<'PY' ... authenticate_user(...) assertions ... PY(all assertions passed).python -m py_compile backend/api/security.py backend/api/routes/auth.py(succeeded).pytest -q backend/tests/test_security.pybut collection failed in this environment due to a missing optional test dependency (httpx), which is unrelated to the auth code changes.Codex Task