Use public logo URL to avoid binary diff and harden auth loading state#83
Merged
fuzziecoder merged 1 commit intocodex/fix-remaining-issues-and-raise-prfrom Feb 24, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7079b81
into
codex/fix-remaining-issues-and-raise-pr
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
loadingif Supabase session retrieval hangs or emits stale updates.Description
src/lib/assets.tsthat exportslogoUrl =${import.meta.env.BASE_URL}logo.jpg`` and removedsrc/assets/logo.jpgso the PR contains no binary diffs.logoUrlinstead of"/logo.jpg"inLogin,Signup,SidebarandFlexibleAIso the logo remains centralized and works under arbitrary base paths.useAuthinsrc/hooks/useAuth.tsby adding anisMountedguard, a 5s fallbackloadingTimeout, explicit.catch/.finallyhandling forgetSession(), and cleanup logic that clears the timeout and unsubscribes the Supabase subscription on unmount soloadingalways resolves and no stale state updates occur.Testing
npm run build(which runstsc -b && vite build) and the build completed successfully.Codex Task