Skip to content

fix: enforce catalog integrity for order item creation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dharapandya85 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: enforce catalog integrity for order item creation #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
455386d
fix: enforce catalog integrity for order item creation
dharapandya85 Mar 4, 2026
ba3d53b
fix: add type guard and safe property checks for parsedItems validation
dharapandya85 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions backend/db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,23 @@ export const database = {

createOrder({ spotId, userId, items }) {
const parsedItems = items.map((item) => {
if (
!item ||
typeof item!== 'object' ||
Array.isArray(item)
)
{
throw new Error('Invalid item format');
}
if(
//if item has it's own property
Object.prototype.hasOwnProperty.call(item, 'name') ||
Object.prototype.hasOwnProperty.call(item, 'unitPrice') ||
Object.prototype.hasOwnProperty.call(item, 'total')
)
{
throw new Error('Do not provide name, unitPrice, or total. These are derived from catalog. ')
}
const quantity = Number(item.quantity || 0);
if (!item.productId || !Number.isInteger(quantity) || quantity <= 0) {
throw new Error('Each order item must include productId and a positive integer quantity');
Expand Down