Improve ordering #54
Open
Improve ordering #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #28
Second commit is a fix for the count calculation, which is bugged on main (top-right number sometimes shows wrong result count, eg when filtering by rating).
I have not thoroughly tested this with comics/mangas, as I don't use Hybooru for that. For my use-case (images and videos exclusively) it does work as intended and is nice to have.
One thing that could probably be improved is the placement of the previous/next control, right now it's on the sidebar, which is fine for horizontal screens, but might be annoying on mobile in some cases ; will have to get some readers' feedback on that!