KikoDevv/Map visibility patch

[kikoDevv]

This PR removes the type=module from the script tag. This will make sure window.initMap is available on the global scope when the Google Maps API calls it as a callback. The rest of the edited files are from another unmerged PR.

Summary by CodeRabbit

• Style

  • Enhanced styling for UI elements with improved button appearance, font inheritance, and proper spacing adjustments to ensure visual consistency across the application.

• Bug Fixes

  • Improved logout security by transitioning from link-based navigation to form-based submission.
  • Fixed script loading configuration for enhanced compatibility.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

These changes modify frontend styling and interaction patterns. The CSS main element is reset with default property removals, logout functionality is converted from an anchor link to a POST-form submission, and the map script is loaded as a regular script rather than a module.

Changes

Cohort / File(s)	Summary
CSS Styling backend/src/main/resources/static/css/styles.css	Main element reset with properties: background: none, border: none, cursor: pointer, font: inherit, padding: 0; existing transition property retained.
Template Updates backend/src/main/resources/templates/fragments/navigation.html, backend/src/main/resources/templates/index.html	Logout navigation item replaced with POST form containing styled button (previously anchor link); map script tag converted from module-type to regular script loading.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kikoDevv/map-visibility-patch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jenkins-cd-for-zipp]

Jenkins Build #1 Summary (for PR #135)

• Status: SUCCESS
• Duration: 1 min 34 sec
• Branch: PR-135
• Commit: 8a36882
• Docker Image: 192.168.0.82:5000/zipp:8a36882 (pushed to registry)

Details:

• Checkout: Successful
• Build & Scan: Passed
• Push: Successful

All stages passed—no issues detected.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16a3dea and 8a36882.

📒 Files selected for processing (3)

• backend/src/main/resources/static/css/styles.css
• backend/src/main/resources/templates/fragments/navigation.html
• backend/src/main/resources/templates/index.html

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: PR Build
• GitHub Check: Jenkins
• GitHub Check: Build, Test & Analyze

🔇 Additional comments (2)

backend/src/main/resources/static/css/styles.css (1)

88-92: Appropriate button-reset styles for navigation link appearance.

The added properties (background: none, border: none, cursor: pointer, font: inherit, padding: 0) are standard button-reset styles that allow the logout button to visually match navigation links.

Note: These styles are correctly designed for button elements. However, in navigation.html, the navigation__link class is currently applied to both the form container and the button, which may cause unintended styling of the form element. This has been flagged separately.

backend/src/main/resources/templates/index.html (1)

59-59: Correct fix for Google Maps callback accessibility.

Removing type="module" allows window.initMap to be accessible in the global scope when the Google Maps API invokes the callback. The file does not use ES6 module syntax (import/export statements), so this change is safe and resolves the visibility issue.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud