Conversation
WalkthroughThe pull request adds environment variables to the Kubernetes Deployment manifest generated by the Jenkinsfile. These additions configure Google OAuth2 client credentials (retrieved from a Kubernetes secret), OAuth2 scopes, and scheduled cleanup job settings for report expiration and deletion. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Possibly related issues
Possibly related PRs
Suggested reviewers
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Jenkinsfile (1)
251-256: Cleanup configuration looks reasonable.The values appear sensible:
- 30-day retention period
- Daily expiration check at midnight
- Daily deletion at 2:30 AM
The cron expressions use 6-field Quartz format, which should work with Spring's
@Scheduledannotation if that's what the application uses.Consider parameterizing these values at the Jenkinsfile environment block (lines 10-39) for easier operational tuning without modifying the pipeline logic:
REPORT_DELETEEXPIREDAFTERDAYS = '30' CLEANUP_EXPIRE_CRON = '0 0 * * * ?' CLEANUP_DELETE_CRON = '0 30 2 * * ?' OAUTH2_SCOPE = 'openid,profile,email'Then reference them in the manifest:
- - name: REPORT_DELETEEXPIREDAFTERDAYS - value: "30" + - name: REPORT_DELETEEXPIREDAFTERDAYS + value: "${REPORT_DELETEEXPIREDAFTERDAYS}"
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Jenkinsfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: PR Build
- GitHub Check: Jenkins
- GitHub Check: Build, Test & Analyze
🔇 Additional comments (2)
Jenkinsfile (2)
249-250: The scope configuration is correct. Spring Boot supports comma-separated values for list properties in configuration, and comma-separated scope values like "openid,profile,email" are the standard format for Spring Security OAuth2 client registration. Environment variables can be used when binding to object lists, so this format will be properly parsed by Spring Boot without requiring spaces or alternative delimiters.
239-248: Verify if non-prefixed GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET (lines 224-233) are still used by application code.The Spring-prefixed environment variables are correctly mapped. However, if the application has been fully migrated to Spring's OAuth2 auto-configuration, the non-prefixed variables on lines 224-233 may be redundant and should be removed. Only keep them if custom application code still references
GOOGLE_CLIENT_IDorGOOGLE_CLIENT_SECRETdirectly.
|
2 participants
Pull Request Type
Description
This PR fixes deployment failures by adding required env vars to the Jenkinsfile-generated deployment.yaml. It resolves startup crashes from missing report cleanup configs (introduced in #114) and incomplete Google OAuth2 setup (from #89). No changes to app code, only pipeline config.
Key Features
How Has This Been Tested?
Linked issues
This PR closes issue #132
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.