fix(#6266): skip non-source artifacts in lint-mint-embed-sync - #6267
Conversation
The lint-mint-embed-sync script iterated all non-test files in internal/mint/ and internal/mintcore/, causing spurious DESYNC errors when non-Go artifacts (coverage.out, .prof, .test) were present. This blocked agent workflows that ran `go test -coverprofile` before the embed-sync pre-commit hook. Add an allowlist filter to both loops so only *.go, go.mod, and go.sum files are checked against their .embed counterparts. Any other file (coverage profiles, test binaries, editor temporaries) is now skipped. Also add coverage.out to .gitignore to prevent accidental commits (partially addresses #841). Note: pre-commit could not run in the sandbox due to network restrictions (HTTP 403 on git fetch). The post-script runs it authoritatively on the runner. Closes #6266
|
🤖 Finished Review · ✅ Success · Started 10:08 PM UTC · Completed 10:17 PM UTC Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR fixes a bug in the mint embed sync linting script (hack/lint-mint-embed-sync) and is authorized by issue #6266 which is labeled component/mint and type/bug |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
|
🤖 Finished Retro · ✅ Success · Started 9:40 AM UTC · Completed 9:55 AM UTC Commit: |
Retro: PR #6267 — skip non-source artifacts in lint-mint-embed-syncOutcome: Merged successfully. Clean end-to-end self-healing cycle with no fix rounds. Timeline
AssessmentThis is the self-healing loop working as designed. The retro agent identified the root cause of a code agent failure, filed a well-structured issue, and the triage → code → review pipeline resolved it in ~21 minutes of agent compute with zero rework. The triage agent added genuine value by catching the Review quality: The review agent's approval was correct — the change is a 13-line mechanical fix to a shell script that passed all CI checks. The "Looks good to me" summary is appropriate depth for this scope. Existing issues in fullsend-ai/agents already track shell script review improvements (#131, #490, #796). Autonomy readiness: The human reviewer approved with no comments, matching the review agent's judgment. For this class of change — small, mechanical shell script fixes for bugs identified by the retro agent, with full CI coverage — the review agent's verdict was sufficient. This provides mild evidence for fullsend-ai/fullsend#5353 (tracking autonomy readiness on fully-covered bug fixes). No proposals. The workflow executed cleanly. No other lint scripts in |
1 participant
Summary
Fix the
lint-mint-embed-syncpre-commit hook to skip non-Go-source artifacts (likecoverage.out,.prof,.test) that may appear ininternal/mint/orinternal/mintcore/during development or agent runs. Also addscoverage.outto.gitignoreto prevent accidental commits.Related Issue
Closes #6266
Changes
*.go,go.mod,go.sum) to both file-iteration loops inhack/lint-mint-embed-sync, so only deployable source files are checked against their.embedcounterpartscoverage.outto.gitignore(partially addresses Expand .gitignore with missing language-specific patterns #841)Testing
coverage.outininternal/mintcore/no longer triggers a DESYNC errorconfig.gowithout updating its embed copy) is still caughtinternal/mint/(.out,.prof,.test) are also skippedChecklist
!for breaking changes)Closes #6266
Post-script verification
agent/6266-skip-non-source-artifacts)124c49ddf7d55efeb4f8b76fa5502b46405bde50..HEAD)