docs(#6163): add staging warning to go-code.md coverage procedure - #6164
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#6163): add staging warning to go-code.md coverage procedure#6164fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The "Verifying patch coverage locally" section in go-code.md step 1 was missing a warning that new files must be staged before running `git diff --name-only`. Without staging, new Go files are invisible to the command and the coverage check silently skips them. Add the same staging note that SKILL.md step 1 already includes, keeping the two coverage procedures consistent. Closes #6163
|
🤖 Finished Review · ✅ Success · Started 6:01 AM UTC · Completed 6:09 AM UTC Commit: |
Site previewPreview: https://a444f89c-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR modifies documentation under docs/contributing/ |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a staging warning to the "Verifying patch coverage locally" procedure in
docs/contributing/go-code.mdstep 1, matching the equivalent warning already present inskills/check-patch-coverage/SKILL.mdstep 1. Without this note, an agent following go-code.md would not know togit addnew files before runninggit diff --name-only, causing the coverage check to silently skip unstaged new files.Changes
git add)" note to step 1 of the coverage procedure indocs/contributing/go-code.mdskills/check-patch-coverage/SKILL.mdTesting
docs/contributing/go-code.mdandskills/check-patch-coverage/SKILL.mdcontain equivalent staging warningsChecklist
!for breaking changes)Closes #6163
Post-script verification
agent/6163-add-staging-warning)3c7f5d034d3f9ace8efd3608a6322903da907809..HEAD)