fix: update site-build workflow for website/ → docs/ move

[maruiz93]

Summary

• Update paths in the "Build Doc Site" workflow to reflect fullsend's website/ → docs/ reorganization (commit 8f3a4363)
• Bump actions/checkout to v7.0.1 and actions/setup-node to v6.5.0 to match fullsend repo
• Add comments explaining the cross-repo symlink and why npx vitepress build docs is used instead of npm run docs:build

Test plan

• "Build Doc Site" check passes on this PR (setup-node cache resolves, npm ci succeeds, vitepress build completes)

Closes #50

🤖 Generated with Claude Code

[qodo-code-review]

PR Summary by Qodo

Fix doc-site build workflow after fullsend website/ → docs/ reorg

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

AI Description

• Update Build Doc Site workflow paths for fullsend’s website/ → docs/ move.
• Align pinned GitHub Actions versions with upstream fullsend workflow.
• Preserve experiments content injection via symlink and build with VitePress directly.

Diagram

graph TD
  W["site-build.yml"] --> E[("experiments checkout")] --> F[("fullsend checkout")] --> N["setup-node + npm cache"] --> I["npm ci"] --> S["symlink docs/experiments"] --> B["vitepress build docs"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Run `npm run docs:build` and configure submodule auth

• ➕ Keeps build invocation aligned with fullsend’s intended scripts
• ➕ Avoids relying on VitePress CLI behavior staying stable
• ➖ Requires SSH keys or token-based auth for submodule update in CI
• ➖ Higher maintenance and greater risk of intermittent CI failures

2. Copy experiments content into docs/ instead of symlinking

• ➕ Avoids symlink edge-cases on some runners/tools
• ➕ More explicit, less dependent on filesystem link semantics
• ➖ Extra build step and potentially slower CI
• ➖ Risk of stale content if copy step misses paths or exclusions

Recommendation: Keep the current approach: adjust paths for the docs/ move, replace the experiments submodule with a symlink, and run npx vitepress build docs directly. It minimizes CI secrets/auth complexity while preserving the cross-repo “combined site” build behavior.

Files changed (1) +12 / -9

Other (1) +12 / -9

site-build.ymlFix doc-site build workflow paths and VitePress build invocation +12/-9

Fix doc-site build workflow paths and VitePress build invocation

• Updates the workflow to install/build from the fullsend repo root after the VitePress site moved from website/ to docs/. Adjusts npm cache dependency path to the root package-lock.json, refreshes pinned checkout/setup-node action SHAs, and replaces the previous submodule/symlink steps with a single docs/experiments symlink plus a direct 'vitepress build docs' call to avoid submodule updates.

.github/workflows/site-build.yml

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 12:13 PM UTC · Completed 12:24 PM UTC

Commit: ffb7906 · View workflow run →

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[fullsend-ai-review]

Review

Findings

Medium

• [protected-path] .github/workflows/site-build.yml — This PR modifies a file under the protected .github/ path. The linked issue (Build Doc Site workflow broken since fullsend moved website/ to docs/ #50) provides clear context for why the workflow file needs updating (fullsend's website/ → docs/ reorganization broke the build), and the changes are well-scoped to the reported problem. Human approval is always required for protected-path changes, regardless of context.

Low

• [scope-creep] .github/workflows/site-build.yml:20 — Dependency version bumps (actions/checkout v7.0.0→v7.0.1, actions/setup-node v6.4.0→v6.5.0) are not explicitly authorized by issue Build Doc Site workflow broken since fullsend moved website/ to docs/ #50. The issue authorizes fixing the broken workflow by updating paths, not bumping action versions. The PR body acknowledges these bumps are to "match fullsend repo" which is a separate maintenance concern.
  Remediation: Remove the dependency version bumps from this PR and submit them separately, or update issue Build Doc Site workflow broken since fullsend moved website/ to docs/ #50 to explicitly authorize bumping dependencies.

---

Labels: PR fixes a broken CI workflow (.github/workflows/) under protected paths

[fullsend-ai-review]

See the review comment for full details.

[fullsend-ai-retro]

🤖 Finished Retro · ✅ Success · Started 7:54 AM UTC · Completed 8:04 AM UTC

Commit: ffb7906 · View workflow run →

[fullsend-ai-retro]

Retro: PR #51 — fix site-build workflow for website/ to docs/ move

Timeline

1. Issue Build Doc Site workflow broken since fullsend moved website/ to docs/ #50 filed (Aug 11, 10:53 UTC) — maruiz93 reported the Build Doc Site workflow was broken after fullsend commit 8f3a4363 moved website/ to docs/.
2. Triage agent (run 31484207332, 10:54–10:57 UTC) — Correctly identified root cause, confirmed fullsend/website/ no longer exists, and outlined three required changes to site-build.yml. Flagged requires_workflow_changes: true and warned: "The code agent cannot modify workflow files under current permissions — a human PR or maintainer action is required."
3. User invoked /fs-code (11:00 UTC) — Despite the triage warning, the user triggered the code agent. The triage comment's "Next steps" footer had unconditionally advertised /fs-code as an option, contradicting the warning above it.
4. Code agent (run 31484740965, 11:01–11:08 UTC) — Ran for ~4 minutes (251s), generated the correct fix (exit code 0), but the post-code push was rejected twice because the GitHub App token lacks workflows permission.
5. Human created PR fix: update site-build workflow for website/ → docs/ move #51 (12:12 UTC) — maruiz93 manually opened the PR with the same fix plus minor action version bumps.
6. Review agent (run 31490139737, 12:13–12:24 UTC) — Posted comment-only verdict (could not approve due to protected-path policy) with two findings: (a) medium-severity protected-path flag for .github/workflows/, (b) low-severity scope-creep flag for action version bumps not authorized by issue Build Doc Site workflow broken since fullsend moved website/ to docs/ #50.
7. Human responded (Aug 13, 07:50 UTC) — Justified the version bumps as intentional upstream alignment with security benefits (undici fix in setup-node v6.5.0).
8. PR merged (Aug 13, 07:51 UTC) — Merged by the author without a formal GitHub APPROVED review.

Workflow quality assessment

Triage: strong. The triage agent correctly diagnosed the root cause, verified the current repo layout, and warned about the code agent's limitation. The only issue was the contradictory "Next steps" footer (see proposal below).

Code agent: wasted run. The agent successfully generated the correct fix but couldn't push it — a predictable failure given the triage agent's warning. This wasted ~4 minutes of compute and token budget.

Review: reasonable. The protected-path finding was appropriate. The scope-creep finding about version bumps was debatable — the bumps were minor, related to the fix, and had independent justification — but flagging it prompted a useful clarification from the author.

Evidence for existing issues

• fullsend#3627, #3814, agents#139 — This workflow is a textbook instance of the wasted code agent run on workflow files. The triage agent's requires_workflow_changes signal was correctly set but not acted upon by the dispatch layer or post-triage footer.
• agents#460 — The unconditional /fs-code footer contributed to the wasted run. However, #460 focuses on repos without a code agent configured; it does not cover issues where the code agent exists but can't handle the specific change (see proposal below).
• fullsend#2394 — The scope-creep finding about minor action version bumps is another instance of the review agent flagging closely related maintenance changes as out of scope.

Proposals filed

• Post-triage footer should suppress /fs-code when triage flags requires_workflow_changes (in fullsend-ai/agents)