Skip to content

fix(codex): grace fallback for thread/resume failure on Codex 0.142+ #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
u-ichi wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −12
Open

fix(codex): grace fallback for thread/resume failure on Codex 0.142+ #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions scripts/drivers/types/codex/codex-bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,19 +772,28 @@ class CodexBridge {
console.error(`codex-bridge: discovered loaded thread ${this.threadId}`);
}
if (this.threadId) {
const response = await this.client.request("thread/resume", {
threadId: this.threadId,
cwd: this.opts.project,
runtimeWorkspaceRoots: [this.opts.project],
excludeTurns: true,
});
if (!response.thread || response.thread.id !== this.threadId) {
die("thread/resume did not return the requested thread id");
try {
const response = await this.client.request("thread/resume", {
threadId: this.threadId,
cwd: this.opts.project,
runtimeWorkspaceRoots: [this.opts.project],
excludeTurns: true,
});
if (!response.thread || response.thread.id !== this.threadId) {
die("thread/resume did not return the requested thread id");
}
const type = response.thread.status && response.thread.status.type;
this.threadIdle = type !== "active";
this.turnActive = type === "active";
console.error(`codex-bridge: resumed thread ${this.threadId}`);
} catch (err) {
// Codex 0.142+ の --remote セッションでは rollout が作成されないため
// thread/resume が失敗する。turn/start は threadId だけで動作するので
// デフォルト状態 (idle) で続行する。
console.error(`codex-bridge: thread/resume failed (${err.message}); proceeding without resume`);
this.threadIdle = true;
this.turnActive = false;
}
const type = response.thread.status && response.thread.status.type;
this.threadIdle = type !== "active";
this.turnActive = type === "active";
console.error(`codex-bridge: resumed thread ${this.threadId}`);
return;
}
const response = await this.client.request("thread/start", {
Expand Down