Skip to content

chore: Upgrade to new error format (after ftes/playwright_ex#58 drops support for 1.60) - #184

Merged
ftes merged 2 commits into
mainfrom
push-nmryrqtzqymn
Jul 28, 2026
Merged

chore: Upgrade to new error format (after ftes/playwright_ex#58 drops support for 1.60)#184
ftes merged 2 commits into
mainfrom
push-nmryrqtzqymn

Conversation

@ftes

@ftes ftes commented Jun 17, 2026

Copy link
Copy Markdown
Owner

@ftes
ftes force-pushed the push-nmryrqtzqymn branch 2 times, most recently from 7da4aa3 to 5626e51 Compare June 17, 2026 07:02
@ftes

ftes commented Jun 17, 2026

Copy link
Copy Markdown
Owner Author

@Wigny if you want to take a look, latest commit in this PR adapts assert_screenshot to ftes/playwright_ex#58 which drops support for playwright 1.60 and changes the error response slightly (error_details included as second tuple element).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6b0e52e6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mix.lock Outdated
Comment thread lib/phoenix_test/playwright.ex Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14683caa73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/phoenix_test/playwright_test.exs Outdated
@ftes
ftes force-pushed the push-nmryrqtzqymn branch from 14683ca to b574efc Compare June 17, 2026 07:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b574efcc82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/phoenix_test/playwright.ex
@ftes
ftes force-pushed the push-nmryrqtzqymn branch from b574efc to a9c7bc0 Compare June 18, 2026 05:15
@ftes
ftes force-pushed the push-nmryrqtzqymn branch from a9c7bc0 to 6736dbf Compare July 28, 2026 10:52
@ftes
ftes enabled auto-merge (squash) July 28, 2026 10:52
@ftes
ftes merged commit 7c64fb8 into main Jul 28, 2026
3 checks passed
@ftes
ftes deleted the push-nmryrqtzqymn branch July 28, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant