Fix invalid signature file when the fslex header defines a module - #243
Merged
Conversation
The header of a .fsl file is repeated in the generated signature file so that its module declaration and opens are visible there. Any line starting with "module " was copied, including a nested module definition, whose body is not part of the signature file. The header was also written without a trailing newline, so the first "/// Rule ..." comment ended up on the same line. A header containing "module Ranges =" therefore produced "module Ranges =/// Rule token" in the signature file, which does not compile (FS0010). Only copy a module declaration now, and write every header line on its own line. fsprojects#240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header of a .fsl file is repeated in the generated signature file so that its module declaration and opens are visible there. Any line starting with "module " was copied, including a nested module definition, whose body is not part of the signature file. The header was also written without a trailing newline, so the first "/// Rule ..." comment ended up on the same line.
A header containing "module Ranges =" therefore produced "module Ranges =/// Rule token" in the signature file, which does not compile (FS0010). Only copy a module declaration now, and write every header line on its own line. #240