Skip to content

Prepare the user and emit event only when the user entity is new - #170

Merged
chives merged 5 commits into
fsi-open:masterfrom
rn0:prepare_fix
Oct 13, 2026
Merged

chives merged 5 commits into
fsi-open:masterfrom
rn0:prepare_fix

Conversation

@rn0

@rn0 rn0 commented Oct 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@rn0
rn0 force-pushed the prepare_fix branch 2 times, most recently from f43b185 to e58a925 Compare October 12, 2026 11:27
rn0 added 2 commits October 12, 2026 14:36
Compiling templates that combine {% trans_default_domain %} with
|trans filters called without parentheses failed with:

  LogicException: EmptyNode cannot have children.

Since Twig 3.15, a filter called without arguments gets an EmptyNode
as its "arguments" node, and EmptyNode::setNode() always throws.
Older versions of Symfony's TranslationDefaultDomainNodeVisitor
inject the default domain by calling setNode() on that node directly,
which triggers the exception during compilation.

Newer symfony/twig-bridge releases replace the EmptyNode with a fresh
Nodes instance before injecting the domain. Updating the bridge fixes
the error for all affected templates, including vendor ones such as
@FSiAdminSecurity/Activation/mail/activation.html.twig.
resend_activation_token:
label: admin.user_list.batch_action.resend_activation_token
element: admin_security_reset_activation_token
actions:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this action should be available only in tests

@chives
chives merged commit 1b9fc4b into fsi-open:master Oct 13, 2026
5 checks passed
@rn0
rn0 deleted the prepare_fix branch October 13, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants