chore: GH-208 delete three dead things and correct a signal name - #280
Open
joaodinissf wants to merge 3 commits into
Open
chore: GH-208 delete three dead things and correct a signal name#280joaodinissf wants to merge 3 commits into
joaodinissf wants to merge 3 commits into
Conversation
Nothing outside output_capture.go referenced OutputCapture, ActionOutput, NewOutputCapture, Add or Get. The package captures action output through outputs.go instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UdUyW1UwSfbg5tT7PYn5KD
PublishBuildFinished named its seventh parameter _, so countLocalResults fed a value that could not reach OperationFinished, which has no field for it. Removing the parameter leaves publishBuildFinished with no use for its results map either. ActionState.Local goes the same way: written on every completed and failed action, read by nothing. ActionResult.Local itself stays. It is set by the sixteen in-daemon sites and drives ExecutedRemotely, which frontseat.proto specifies as false for in-daemon actions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UdUyW1UwSfbg5tT7PYn5KD
Three comments claimed SIGTERM; the code sends os.Interrupt, which is SIGINT. SIGINT is the better choice here — dev servers install Ctrl-C handlers, and syscall.SIGTERM does not compile on Windows — so the comments move to the code rather than the reverse. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UdUyW1UwSfbg5tT7PYn5KD
joaodinissf
force-pushed
the
chore/sweep-triage
branch
from
August 1, 2026 20:25
f55c630 to
91d6005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three deletions and a correction from a codebase sweep. No behaviour changes.
OutputCapture—OutputCapture,ActionOutput,NewOutputCapture,Addand
Gethad no reference outside their own file; the package captures outputthrough
outputs.go. Not to be confused with the protobuffrontseat.ActionOutput,which is a different and very much live type.
The discarded local-action count —
PublishBuildFinishednamed its seventhparameter
_, socountLocalResultscomputed a number that could not reachOperationFinished, which has no field for it. With the parameter gone,publishBuildFinishedhas no remaining use for itsresultsmap either.ActionState.Localgoes the same way: written on every completed and failedaction, read by nothing.
The signal name — three comments claimed SIGTERM where the code sends
os.Interrupt, which is SIGINT. The comments moved to the code rather than thereverse: dev servers install Ctrl-C handlers, and
syscall.SIGTERMdoes notcompile on Windows.
ActionResult.Localitself is deliberately untouched. An earlier reading of itas never-set was wrong — sixteen in-daemon sites set it (conformance, plugin
sync, mise install, fix and generate tasks), and it drives
ExecutedRemotely,which
frontseat.protospecifies as false for in-daemon actions.Verifying that turned up a real defect, filed separately rather than fixed here:
CachedandLocalare set by disjoint code paths, soACTION_STATUS_CACHEDis unreachable and the CLI's
"%d remote, %d local"split has a permanentlyzero local bucket. The unreachable branch is left in place as the only surviving
evidence of the intent.
Relates to #208.
Published with assistance from Claude.