fix(frontseat-daemon): GH-272 name every candidate in an ambiguous ref - #273
Open
joaodinissf wants to merge 1 commit into
Open
fix(frontseat-daemon): GH-272 name every candidate in an ambiguous ref#273joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
resolveEntityRef recorded the first name match and errored on the second, so with three candidates it named whichever pair map iteration reached first and never mentioned the third. In this workspace a Domain, a System and a Component are all called "frontseat", and the message routinely omitted the Component — the only one that can actually be built — while telling the reader to use a full ref. Collect every match and report them sorted. Erroring stays correct for a user-typed selector; only the message needed to become complete and reproducible. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
fix/272-ambiguous-entity-message
branch
from
August 1, 2026 20:25
ba3aaf1 to
8120f6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveEntityRefrecorded the first name match and errored on the second, so with three candidates it named whichever pair map iteration reached first and never mentioned the third.This workspace's own catalog names a Domain, a System and a Component
frontseat, sofrontseat assemble //frontseatsaid:It omitted
component:default/frontseat— the only candidate that can be built — while advising the reader to use a full ref. Now:Erroring remains correct here: this is a user-typed selector and refusing to guess is right. Only the message needed to be complete and reproducible.
The resolver had no tests; this adds them, including one that asserts the message is byte-identical across 50 resolutions of the same ambiguous name. That test fails against the previous code with exactly the truncated message above.
Relates to #272 — which also floats preferring a Component when the other matches are groupings. That is a behaviour change and deliberately not part of this.
This pull request was published with assistance from Claude.