Repository navigation
debug logger: render bash non-zero exits as compact exit-code lines - #51
Open
hello-pollux wants to merge 2 commits into
Open
hello-pollux wants to merge 2 commits into
hello-pollux wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the debug channel, every bash command that exits non-zero (
grepno-match,diffon differing files,gh pr checkswhile pending) is rendered as a full❌ bash failed: <error text>line. For an agent that often runs diagnostic commands where non-zero is the expected result, this floods the log with false alarms.Solution
New
renderToolFailure.tsclassifies failed tool results:Command exited with code Nsuffix, render a compact line:-# bash → exit 1 · <bounded preview of output>.❌ <tool> failed: …shape.Removes
extractToolErrorText.ts(logic folded into the new module). The agent's own turn view of the errored result is unchanged — this only affects debug-channel rendering.Tests
renderToolFailure.test.ts: exit-code extraction, multi-line preview collapsing, output preview capping, genuine-error fallback, compact vs ❌ line formatting.bun run typecheckclean;bun test109 pass.