Conversation
Owner
|
@dinvlad I think it is the right place to do it. I think that it can be slightly optimized by changing the return of signTestComposed . If we are in this workflow, signTestComposed should return the vector without calling PostprcoessSignTest. The vector will then contain -1s and 1s. Then the lines 184 and 185 would become: oblockInv = crypto.CAddConst(cps, oblockInv, -1.0) This is a minor optimization, removing PostprcoessSignTest in this case saves one level and a few operations (add, mult and rescale). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to integrate SF-GWAS with SF-Relate by saving an encrypted relatedness mask file, which is later used by SF-Relate.
@froelich Could you please provide feedback if this is the right approach and place to do it?
Sister PR: hcholab/sfgwas#10