Skip to content

Add simple example#35

Open
xuanngo2001 wants to merge 1 commit intofremail:masterfrom
xuanngo2001:add-example
Open

Add simple example#35
xuanngo2001 wants to merge 1 commit intofremail:masterfrom
xuanngo2001:add-example

Conversation

@xuanngo2001
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2022

Codecov Report

Base: 77.37% // Head: 77.37% // No change to project coverage 👍

Coverage data is based on head (204270e) compared to base (a25d463).
Patch has no changes to coverable lines.

❗ Current head 204270e differs from pull request most recent head 4c7a535. Consider uploading reports for the commit 4c7a535 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   77.37%   77.37%           
=======================================
  Files           2        2           
  Lines         495      495           
=======================================
  Hits          383      383           
  Misses        112      112           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fremail
Copy link
Copy Markdown
Owner

fremail commented Sep 15, 2022

Hi @xuanngo2001! Thank you for PR! Your example is good, but it's too heavy for the "Getting started" section. Not all developers need to sync table structure and add some records on each application run.

So it's better to create a new section at the bottom of README.md and move your example there. Something like "Examples".

Again, thank you for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants