Skip to content

fix(pty): emit BackTab sequence for Shift+Tab #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freecodetiger merged 1 commit into from
Jul 29, 2026
Merged

fix(pty): emit BackTab sequence for Shift+Tab #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/ProGhosttyCore/TerminalCore/PTY/PTYTerminalEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func terminalControlInputData(for event: NSEvent) -> Data? {
case UInt32(NSEnterCharacter), UInt32(NSCarriageReturnCharacter):
return event.modifierFlags.contains(.shift) ? Data([0x0A]) : Data([0x0D])
case UInt32(NSTabCharacter):
return Data([0x09])
return event.modifierFlags.contains(.shift) ? Data("\u{1B}[Z".utf8) : Data([0x09])
case UInt32(NSBackspaceCharacter):
return Data([0x7F])
case 0x1B:
Expand Down
11 changes: 11 additions & 0 deletions Tests/ProGhosttyCoreTests/PTYLaunchTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ struct PTYLaunchTests {
#expect(terminalControlInputData(for: event) == Data([0x0D]))
}

@Test func shiftTabProducesBackTabSequence() throws {
let event = try #require(makeKeyEvent(
keyCode: 48,
characters: "\t",
charactersIgnoringModifiers: "\t",
modifierFlags: [.shift]
))

#expect(terminalControlInputData(for: event) == Data("\u{1B}[Z".utf8))
}

@Test func shellArgumentsUseShellBasename() {
#expect(PTYLaunch.shellArguments(shellPath: "/bin/zsh") == ["zsh"])
}
Expand Down
Loading