Skip to content

Use XDG_CACHE_HOME for logs#217

Open
CameronNemo wants to merge 1 commit into
freebsd:masterfrom
CameronNemo:master-xdgcachehome
Open

Use XDG_CACHE_HOME for logs#217
CameronNemo wants to merge 1 commit into
freebsd:masterfrom
CameronNemo:master-xdgcachehome

Conversation

@CameronNemo

Copy link
Copy Markdown

No description provided.

@ngie-eign

Copy link
Copy Markdown
Contributor
  • Could you please document why this change is being proposed in the commit message?
  • Could you please add Signed-off-by: to your commits?

Comment thread doc/kyua.1.in
@@ -300,7 +307,7 @@ Also, please include a copy of the log file corresponding to the problem
you are experiencing.
Unless you have changed the location of the log files, you can most likely

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially misleading after this change, as the location isn't clearcut if $XDG_CACHE_HOME is not set.

Comment thread doc/kyua.1.in
uses this to wrap long lines.
If not present, the width of the screen is determined from the terminal
stdout is connected to, and, if the guessing fails, this defaults to infinity.
.It Va XDG_CACHE_HOME

@ngie-eign ngie-eign May 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's possibly duplicate/misleading text under the $HOME description below after this change.

@ngie-eign ngie-eign left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see prior comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants