Skip to content

VST3: never hand a wrapper-owned parameter id to the plugin #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
defiantnerd merged 1 commit into from
Sep 15, 2026
Merged

VST3: never hand a wrapper-owned parameter id to the plugin #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/detail/vst3/parameter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,13 @@ class Vst3Parameter : public Steinberg::Vst::Parameter
if (!isPreset || (info.flags & Steinberg::Vst::ParameterInfo::kIsHidden)) return 0;
return info.stepCount + 1;
}
// Invented by the wrapper, with no CLAP counterpart, so neither `id` nor
// `param_index_for_clap_get_info` may ever be handed to the plugin.
bool isWrapperOwned() const
{
return isMidi || isPreset;
}

// copies from the clap_param_info_t
uint32_t param_index_for_clap_get_info = 0;
clap_id id = 0;
Expand Down
12 changes: 6 additions & 6 deletions src/wrapasvst3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ void ClapAsVst3::syncParameterValuesFromClap()
for (decltype(len) i = 0; i < len; ++i)
{
auto p = static_cast<Vst3Parameter *>(parameters.getParameterByIndex(i));
if (p->isMidi) continue;
if (p->isWrapperOwned()) continue;
double val;
if (_plugin->_ext._params->get_value(_plugin->_plugin, p->id, &val))
{
Expand Down Expand Up @@ -647,7 +647,7 @@ tresult PLUGIN_API ClapAsVst3::getParamStringByValue(Vst::ParamID id, Vst::Param
return kResultOk;
}

if (param->isMidi)
if (param->isWrapperOwned())
{
auto r = std::to_string((int)val);

Expand Down Expand Up @@ -683,7 +683,7 @@ tresult PLUGIN_API ClapAsVst3::getParamValueByString(Vst::ParamID id, Vst::TChar
char inbuf[128];
m.copyTo8(inbuf, 0, 128);
double out = 0.;
if (param->isMidi)
if (param->isWrapperOwned())
{
return Steinberg::kResultFalse;
}
Expand Down Expand Up @@ -1591,9 +1591,9 @@ void ClapAsVst3::param_rescan(clap_param_rescan_flags flags)
for (decltype(len) i = 0; i < len; ++i)
{
auto p = static_cast<Vst3Parameter *>(parameters.getParameterByIndex(i));
// Neither names a CLAP parameter: the selector's index is left at 0, so
// get_info would rename the host's program control after parameter 0.
if (p->isMidi || p->isPreset) continue;
// The selector's index is left at 0, so get_info would otherwise rename
// the host's program control after parameter 0.
if (p->isWrapperOwned()) continue;
clap_param_info_t info;
if (_plugin->_ext._params->get_info(_plugin->_plugin, p->param_index_for_clap_get_info, &info))
{
Expand Down
Loading