Skip to content

VST3: two context-menu bridge fixes #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
defiantnerd merged 2 commits into from
Sep 13, 2026
Merged

VST3: two context-menu bridge fixes #542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5db5e6
VST3: a null context-menu target is the global context, not a crash
defiantnerd Sep 13, 2026
f79bfa6
VST3: mask the context-menu parameter id like every other one
defiantnerd Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/wrapasvst3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,13 +2099,19 @@ bool ClapAsVst3::context_menu_populate(const clap_context_menu_target_t *target,
if (!builder->supports(builder, CLAP_CONTEXT_MENU_ITEM_END_SUBMENU)) return false;
// CLAP_CONTEXT_MENU_ITEM_TITLE is not used by VST3

if (target->kind == CLAP_CONTEXT_MENU_TARGET_KIND_GLOBAL)
// A null target is the global context - see the documentation of
// clap_plugin_context_menu::populate in clap/ext/context-menu.h - so it must
// not be dereferenced. An unrecognised kind still creates no menu at all.
if (target == nullptr || target->kind == CLAP_CONTEXT_MENU_TARGET_KIND_GLOBAL)
{
this->vst3ContextMenu = componentHandler3->createContextMenu(this->_wrappedview, nullptr);
}
if (target->kind == CLAP_CONTEXT_MENU_TARGET_KIND_PARAM)
else if (target->kind == CLAP_CONTEXT_MENU_TARGET_KIND_PARAM)
{
vst3ContextMenuParamID = target->id;
// Parameters are published to the host with the top bit cleared (see
// createParameter() in detail/vst3/parameter.cpp), so that - and not the
// raw clap_id - is the id the host can resolve back to a parameter.
vst3ContextMenuParamID = target->id & 0x7FFFFFFF;
vst3ContextMenu = componentHandler3->createContextMenu(_wrappedview, &vst3ContextMenuParamID);
}
if (vst3ContextMenu)
Expand Down
Loading