This repository was archived by the owner on Nov 9, 2021. It is now read-only.
Use https for guids, links and image sources - #8
Open
philr wants to merge 1 commit into
Open
Conversation
The dilbert.com site now uses https (redirecting http requests). The comic link used to determine the URL of today's strip is a full https URL. The nav-left links used to find links to strips from previous days are relative. The output will therefore contain https guids and links for today's strip, but http guids and links for previous days. This results in duplicate items when processed by an RSS reader. Convert all URLs found to full https URLs (including the protocol- relative URLs used for the images). Resolves fredley#7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dilbert.com site now uses https (redirecting http requests). The comic link used to determine the URL of today's strip is a full https URL. The nav-left links used to find links to strips from previous days are relative.
The output will therefore contain https guids and links for today's strip, but http guids and links for previous days (see the example below). This results in duplicate items when processed by an RSS reader.
This pull request changes the script to convert all URLs found to full https URLs (including the protocol-relative URLs used for the images, resolving #7).