added low battery alert#40
Merged
Merged
Conversation
matthewcwheeler
approved these changes
Dec 13, 2025
Contributor
matthewcwheeler
left a comment
matthewcwheeler
left a comment
There was a problem hiding this comment.
lgtm, just wondering if the alert logic can be cleaned up a bit.
| } | ||
| double batteryVoltage = RobotController.getBatteryVoltage(); | ||
|
|
||
| if(batteryVoltage<= kLowBatteryVoltage && disabledTimer.hasElapsed(kLowBatteryDisabledTime) && lowBatteryCycleCount >= kLowBatteryMinCycles){ |
Contributor
There was a problem hiding this comment.
How often is it the case that cycle count is less than 10, but that the elapsed time is greater than 1.5 (seconds, minutes?)? That is, do you need both checks?
Contributor
Author
There was a problem hiding this comment.
i dont think we need both checks - updated in the newest commit
Contributor
Author
There was a problem hiding this comment.
@matthewcwheeler can you do one more check before i merge?
Signed-off-by: Bang Xiao <bangxiao0927@gmail.com>
bangxiao0927
approved these changes
Dec 20, 2025
Signed-off-by: Bang Xiao <bangxiao0927@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6328 and a few other teams have these low battery alerts so when they are testing or during drive practice they know when to change batteries to maximize the lifetime, I thought we could try it next season, and it will also help during drive practice