Skip to content

fix(ux): change "Try new Print Designer" to "Go to new Print Designer"#520

Open
KerollesFathy wants to merge 4 commits into
frappe:developfrom
KerollesFathy:remove-try-print-designer
Open

fix(ux): change "Try new Print Designer" to "Go to new Print Designer"#520
KerollesFathy wants to merge 4 commits into
frappe:developfrom
KerollesFathy:remove-try-print-designer

Conversation

@KerollesFathy
Copy link
Copy Markdown
Contributor

@KerollesFathy KerollesFathy commented Feb 25, 2026

Resolve: frappe/frappe#37509
Context: frappe/frappe#37509 (comment)


After:

after-remove-try-print-desinger-1772032869777.mp4

@KerollesFathy
Copy link
Copy Markdown
Contributor Author

@NagariaHussain

Comment thread print_designer/print_designer/client_scripts/print.js
@NagariaHussain
Copy link
Copy Markdown
Collaborator

On a second thought, should we make it respect the checkbox instead of removing the link entirely? Or maybe in Framework change the try link to the print designer page link?

The idea of this link is to make them go to the print designer screen. The framework link nudges for install.

@KerollesFathy
Copy link
Copy Markdown
Contributor Author

KerollesFathy commented Mar 4, 2026

@NagariaHussain

Let's Organize our thoughts:

1. Frappe App

  • Responsible for the nudge to install Print Designer
  • Also nudges users to go to the Print Designer page, but this is triggered under the wrong condition (incorrect check on "disable product suggestions")

2. Print Designer App

  • Nudges users with a button labeled "Try New Print Designer" , this label is incorrect, as the app is already installed

Required Actions:

  1. Frappe App → Remove the "Try New Print Designer" link that redirects to the Print Designer page
  2. Print Designer App → Rename the link from "Try New Print Designer""Go to Print Designer"

@KerollesFathy KerollesFathy changed the title fix: remove "Try the new Print Designer" already handled in framework fix(ux): change "Try new Print Designer" to "Go to new Print Designer" Mar 4, 2026
@KerollesFathy
Copy link
Copy Markdown
Contributor Author

@NagariaHussain
Is this pr needed now?

@KerollesFathy
Copy link
Copy Markdown
Contributor Author

@NagariaHussain Is this pr needed now?

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabling Product Suggestions Not Working

2 participants