Fix: don't download chromium if it is configured and installed#487
Closed
trustedcomputer wants to merge 4 commits into
Closed
Fix: don't download chromium if it is configured and installed#487trustedcomputer wants to merge 4 commits into
trustedcomputer wants to merge 4 commits into
Conversation
Don't download chromium if it's chromium_binary_path is configured in common_site_config.json and present. If it is not configured, or if it is configured but not present at the configured path, continue with the logic of checking in the bench directory.
Attribute should be close, not closed
This reverts commit 4003a0a.
Author
|
I am going to re-open this in its own dedicated branch. |
Author
|
Resubmitted in #490 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't download chromium if it's chromium_binary_path is configured in common_site_config.json and present. If it is not configured, or if it is configured but not present at the configured path, continue with the logic of checking in the bench directory.