Skip to content

feat: user can now change the background of the whole document#322

Open
Grolaf wants to merge 4 commits into
frappe:developfrom
Grolaf:develop
Open

feat: user can now change the background of the whole document#322
Grolaf wants to merge 4 commits into
frappe:developfrom
Grolaf:develop

Conversation

@Grolaf
Copy link
Copy Markdown

@Grolaf Grolaf commented Jul 7, 2024

This feature comes to allow user to change the background color, see the video below.

Sans.titre.mp4
  • The filler is mandatory because the div do not ends at the end of the document, but at the end of the user input
  • This also comes with little tricks with margins, obtained during testing. For example, if you remove the margin trick in styles.html, then you'll have a white 1px margin to the right of the document, leaving your print format unusable before cropping.

Please feel free to blame me if there's something wrong with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant