Skip to content

fix(auth): Revalidate user data on login to prevent stale state #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankush210103 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): Revalidate user data on login to prevent stale state #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lib/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,12 @@ export const useFrappeAuth = (options?: SWRConfiguration): {
const login = useCallback(async (credentials:AuthCredentials) => {
return auth.loginWithUsernamePassword(credentials)
.then((m) => {
getUserCookie()
// THE FIX IS HERE:
// Manually trigger a re-fetch of the user data after login.
updateCurrentUser();
return m
})
}, [])
}, [updateCurrentUser]) // ✅And the dependency is added here

const logout = useCallback(async () => {
return auth.logout()
Expand Down