Frappe Doc Create Listener Added#80
Open
Abhishek-Chougule wants to merge 1 commit into
Open
Conversation
Frappe Doc Create Listener Added
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Added useFrappeDocCreateListener Hook for Listening to New Document Creations
Description:
This PR introduces a new custom React hook, useFrappeDocCreateListener, which listens for real-time document creation events in Frappe via WebSockets.
🔹 Features & Functionality:
📡 Subscribes to doctype_subscribe to receive updates for a specific Frappe doctype.
⚡ Listens for doc_create events and triggers a callback when a new document is created.
👥 Tracks active document viewers using the doc_viewers event.
🔄 Handles automatic re-subscription when the socket reconnects.
🛑 Prevents multiple subscriptions using a useRef flag to avoid duplicate event listeners.
🧹 Proper cleanup on unmount to prevent memory leaks.
🔹 Hook Usage Example:
🔹 Why This Is Needed:
Currently, frappe-react-sdk lacks a dedicated hook for listening to new document creations in real-time.
This hook simplifies WebSocket event handling and ensures efficient subscription management.
🔹 Enhancements & Improvements:
Improves real-time data handling in Frappe-based React applications.
Reduces boilerplate code for WebSocket event listeners.
Ensures reliability by automatically re-subscribing after reconnections.
Checklist:
Tested in a Frappe-based React project.
Prevents duplicate subscriptions and ensures proper cleanup.
Includes a callback-based API for flexibility.
Looking forward to feedback and suggestions! 🚀