Repository navigation
fix(reports): keep tree rows grouped when sorting - #243
Merged
Merged
Conversation
Sort sibling groups before numbering and drawing tree rows. Add seven browser regression tests.
Contributor
Author
|
@greptileai deep review |
 |
|
🎉 This PR is included in version 1.21.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sorting a tree Query Report orders every row in one flat list. Children move away from their parents, so expanding a parent can display its rows elsewhere.
Change
Use DataTable's column sort to rank rows, then sort each sibling group and rebuild the tree row order. Preserve report-specific sort callbacks and normal sorting for flat reports.
Before:
Screen.Recording.2026-10-09.at.3.13.07.PM.mov
After:
Screen.Recording.2026-10-09.at.3.20.55.PM.mov