fix(columnmanager): resize body cells while dragging a column - #240
Merged
Merged
Conversation
iamejaaz
approved these changes
Sep 19, 2026
Member
|
@kaulith, once the release is made, could you please create a PR bumping its version in the framework? |
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bvisible
added a commit
to bvisible/datatable
that referenced
this pull request
Sep 29, 2026
Brings in upstream's fixes since our last merge: - the body cells follow a column while it is being resized (frappe#240); - the sticky columns' offsets are recomputed after a column resize (frappe#241); - a column can be sorted on a value it returns (frappe#239); - the tree keeps its expanded rows when a column is frozen (frappe#238); - the toast and the column menu sit above the sticky columns (frappe#237, frappe#236). One conflict, src/style.css: the column menu's z-index. Ours (100) is kept, marked //// Neoffice: upstream's 10 clears the sticky columns but not the layers our desk puts over a list. dist/ rebuilt (rollup), as frappe consumes the built files of this fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a column's resize handle only moved the header cell; the cells below kept their old width until the mouse was released, so the header drifted out of line with its column for the whole drag.
onMouseMoveinbindResizeColumnupdated the column model and calledsetColumnHeaderWidthonly, whilesetColumnWidthandsetBodyStyleran on mouseup. Both now run on every move, so the body and its scroll container follow the drag, and the mouseup handler no longer repeats them. The final width after release is unchanged.Screen.Recording.2026-09-19.at.12.25.31.AM.mov