Repository navigation
feat(sort): sort on a value returned by the column - #239
Merged
Merged
Conversation
Sorting compares `cell.content`, so a column that renders something other than its stored value sorts by the value the user cannot see. `compareValue` already solves this for filtering; `sortValue` is the same idea for sorting. A column with a `sortValue(cell)` function sorts on what that returns. Columns without one are unchanged.
mihir-kandoi
force-pushed
the
feat/column-sort-value
branch
from
September 15, 2026 07:21
a18c41f to
c324075
Compare
Contributor
Author
|
@sokumon 🙏 |
Member
|
Hey sorry for the delay reviewing it now |
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bvisible
added a commit
to bvisible/datatable
that referenced
this pull request
Sep 29, 2026
Brings in upstream's fixes since our last merge: - the body cells follow a column while it is being resized (frappe#240); - the sticky columns' offsets are recomputed after a column resize (frappe#241); - a column can be sorted on a value it returns (frappe#239); - the tree keeps its expanded rows when a column is frozen (frappe#238); - the toast and the column menu sit above the sticky columns (frappe#237, frappe#236). One conflict, src/style.css: the column menu's z-index. Ours (100) is kept, marked //// Neoffice: upstream's 10 clears the sticky columns but not the layers our desk puts over a list. dist/ rebuilt (rollup), as frappe consumes the built files of this fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting compares
cell.content, so a column that renders something other than its stored value sorts by the value the user cannot see. In Frappe this shows up on Link columns that display a document's title field: the cell readsAcme Corpbut sorts underCUST-0099.compareValuealready solves this for filtering.sortValueis the same idea for sorting: a column with asortValue(cell)function sorts on what that returns, and columns without one are unchanged.