Repository navigation
fix(workflow-session): preserve full-history unfinished-call recovery - #3
Merged
franksong2702 merged 2 commits intoNov 7, 2026
Conversation
Backport upstream yyjeqhc#1344 with JSON-ledger restore regression adaptation. Preserve read-only projection and exact invocation identity. Validation: 305 workflow-session tests passed, 10 existing ignored; 42 continuation tests passed; baseline regression failed as expected. Independent static review found no blocking issue. Exact-head CI required.
Backport upstream yyjeqhc#1374 over existing yyjeqhc#1344 recovery fix. Compute unfinished mutations over all retained Session events while keeping presentation bounded. Preserve exact invocation identity, JSON ledger persistence, and no replay. Validation: baseline regression 2 expected failures; final workflow-session 309 passed / 10 ignored; Server tests compile; independent continuation 46 passed and borrowed projections 7 passed / 4 ignored. Independent final review found no blocker. Exact-head CI remains required.
franksong2702
changed the title
franksong2702
marked this pull request as ready for review
November 7, 2026 02:52
franksong2702
merged commit Nov 7, 2026
3ca34f6
into
integrate/reviewed-upstream-20261020
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Backport upstream #1344 and its follow-up #1374 onto the maintained
integrate/reviewed-upstream-20261020branch.Unfinished mutating/shell calls remain visible after resume or another instruction, including starts pushed beyond the 200-event presentation summary but still present in retained Session history. Resolution requires the exact later invocation identity. The reverse scan is bounded by retained history and remains read-only: no execution, replay, permission, retention, persistence-format, or deployment change.
The fork retains JSON-ledger persistence. Tests cover full-history reload, hot/cold parity, serialization privacy, reused identities, duplicated finishes and finish ordering. Fork-only patches remain intact; PR #2 is unchanged.
Final local validation
in_progressinstead ofblocked).cargo check --locked -p webcodex --tests: passed; this is compile evidence, not Server test execution.Current validation report.
Historical #1344 validation.
Exact source and CI
Current head:
22c0643d1067caefe7b400ee97c576a549d23ac2; Git tree4092e57047a31bc1602427f68c90ecf77c3b5ef7exactly matches the locally validated and independently reviewed tree.Exact-head CI run completed successfully on 2026-11-07 at 02:23:24 UTC: 11 jobs successful, 7 path-classifier skips. Required stable aggregates
testandtest-nativepassed. Linux Server (including experimental Code Mode/receipt tests), workspace crates, Runner, tooling, contract and MCP conformance passed. Native Windows/macOS and Docker execution lanes were skipped by the trusted path policy; their aggregate policy checks are not native-platform acceptance. Previous head's CI is historical only.Ready-for-review recheck: CI run 42331382826 passed on the same head at 2026-11-07 03:02:18 UTC, again with 11 successful jobs and 7 policy skips. This latest run completed before merge.
No full local Server runtime test, native Windows/macOS/ARM64, real Host/MCP, crash/power-loss or deployed Server/Runner acceptance is claimed. No release, deployment, or service restart. Merged into
integrate/reviewed-upstream-20261020on 2026-11-07 at 03:02:51 UTC as3ca34f67. The merge tree remains exactly4092e57047a31bc1602427f68c90ecf77c3b5ef7.