Spawn tart with an inherited environment and its bin dir on PATH#136
Open
DDRBoxman wants to merge 1 commit into
Open
Spawn tart with an inherited environment and its bin dir on PATH#136DDRBoxman wants to merge 1 commit into
DDRBoxman wants to merge 1 commit into
Conversation
tart was spawned with a replaced environment containing at most TART_HOME, so
the child process had no usable PATH. tart execs helper binaries by name and
resolves them through PATH — most visibly `softnet` for `--net-softnet`, which
failed with InitializationFailed("softnet not found in PATH") when Tartelet ran
as a GUI app (whose launchd PATH omits e.g. the Homebrew bin directory).
Inherit the launching process's environment instead of replacing it, overlay
TART_HOME, and prepend the directory of the located tart binary to PATH. tart's
helpers are installed alongside tart, so reusing the path we already resolve to
launch tart makes them discoverable without hardcoding any install location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inherit the launching process's environment instead of replacing it, overlay TART_HOME, and prepend the directory of the located tart binary to PATH. tart's helpers are installed alongside tart, so reusing the path we already resolve to launch tart makes them discoverable without hardcoding any install location.
Motivation and Context
tart was spawned with a replaced environment containing at most TART_HOME, so the child process had no usable PATH. tart execs helper binaries by name and resolves them through PATH — most visibly
softnetfor--net-softnet, which failed with InitializationFailed("softnet not found in PATH") when Tartelet ran as a GUI app (whose launchd PATH omits e.g. the Homebrew bin directory).Screenshots (if appropriate):
Types of changes