Open
Conversation
Contributor
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository |
Contributor
|
@cursor review |
jirevwe
reviewed
Jan 23, 2026
Contributor
|
@cursor review |
Contributor
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
f10c521 to
5038d23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades requestmigrations from v0.4.0 to v2, switching from handler-based migrations to type-based migrations.
Key Changes
models.CreateEndpoint,models.EndpointResponse) rather than per handlerh.Versioning.For(r)to get aMigrator, then callmigrator.Unmarshal()/migrator.Marshal()interface{}fields at runtime, enabling migrations to work correctly forPagedResponse.Contentcontaining[]EndpointResponsecontext.Contextfor proper request scopingFiles Changed
api/handlers/handlers.go- RenamedRMtoVersioningfieldapi/handlers/endpoint.go- Updated all handlers to use new v2 APIapi/handlers/portal_link.go- Updated handlers to use new v2 APIapi/api.go- Renamedrmtoversioningfieldapi/migrations/*.go- Refactored migrations to implementTypeMigrationinterface withcontext.Contextgo.mod- Upgrades requestmigrations to v2.1.0Migration Behavior Preserved
v20240101:http_timeoutandrate_limit_durationstring↔uint64 conversion,advanced_signaturesdefaultv20240401:url↔target_urlandname↔titlefield renamesv20251124:owner_idvalidation for portal linksTest Plan
go test -v ./api/migrations/...)Note
Upgrades request versioning to requestmigrations v2 and refactors API to type-based migrations with per-type registration and new marshal/unmarshal flow.
github.com/subomi/requestmigrationswithv2; wireversioninginto routers/handlers and renameRM→VersioningVersioning.For(r)+migrator.Unmarshal/Marshal; adjust request body reading and wrap migrated payload inServerResponse.DataRegisterMigrationsusing genericRegister[T]forCreateEndpoint,UpdateEndpoint,EndpointResponse, and portal link requests; remove legacy handler-oriented migrationsadvanced_signatures), 2024-04-01 (field renames), 2025-11-24 (portal linkowner_idvalidation) with unit testsfatih/structs, bump torequestmigrations/v2Written by Cursor Bugbot for commit 319b95b. This will update automatically on new commits. Configure here.