Reject a constant write_to_port port index at or above MAX_SERIAL_PORTS - #250
Draft
zimri-leisher wants to merge 1 commit into
Draft
zimri-leisher wants to merge 1 commit into
zimri-leisher wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| from fpy.error import CompileError, diagnostic_context | ||
| from fpy.macros import TIME_MACRO | ||
| from fpy.macros import MAX_SERIAL_PORTS_NAME, TIME_MACRO, WRITE_TO_PORT_MACRO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAX_SERIAL_PORTSis the sentinel one past the last real serial port, and the sequencer rejects any index at or above it withSERIAL_PORT_INVALID_INDEX. The compiler accepted it anyway, so this compiled and then always failed at run time (on wasm with no exit code at all):The port argument is already required to be a compile-time constant, so the check is now made there:
A dictionary whose enum declares no sentinel gives nothing to check against, so those indices are still left to the run-time check.