Skip to content

Simplify bytecode numeric conversion dispatch #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimri-leisher wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Simplify bytecode numeric conversion dispatch #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions src/fpy/codegen_fpybc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,13 @@
AstWhile,
)

_NUMERIC_CONVERSIONS: dict[tuple[FpyType, FpyType], type[Directive]] = {
(U64, F64): UnsignedIntToFloatDirective,
(I64, F64): SignedIntToFloatDirective,
(F64, I64): FloatToSignedIntDirective,
(F64, U64): FloatToUnsignedIntDirective,
}


@dataclass
class FpybcBackendState(BackendState):
Expand Down Expand Up @@ -566,25 +573,11 @@ def convert_numeric_type(
from_64_bit = self.get_64_bit_numeric_type(from_type)
to_64_bit = self.get_64_bit_numeric_type(to_type)

# now convert between int and float if necessary
if from_64_bit == U64 and to_64_bit == F64:
dirs.append(UnsignedIntToFloatDirective())
from_64_bit = F64
elif from_64_bit == I64 and to_64_bit == F64:
dirs.append(SignedIntToFloatDirective())
from_64_bit = F64
elif from_64_bit == U64 or from_64_bit == I64:
assert to_64_bit == U64 or to_64_bit == I64
# conversion from signed to unsigned int is implicit, doesn't need code gen
from_64_bit = to_64_bit
elif from_64_bit == F64 and to_64_bit == I64:
dirs.append(FloatToSignedIntDirective())
from_64_bit = I64
elif from_64_bit == F64 and to_64_bit == U64:
dirs.append(FloatToUnsignedIntDirective())
from_64_bit = U64

assert from_64_bit == to_64_bit, (from_64_bit, to_64_bit)
# Only int/float conversions need an instruction at 64-bit width;
# signed/unsigned integer conversions preserve the same bits.
conversion = _NUMERIC_CONVERSIONS.get((from_64_bit, to_64_bit))
if conversion is not None:
dirs.append(conversion())

# now truncate back down to desired size
dirs.extend(
Expand Down
Loading