Skip to content

Simplify numeric common-type selection #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimri-leisher wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Simplify numeric common-type selection #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions src/fpy/semantics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,9 @@
TIME,
TIME_BASE,
U8,
U16,
U32,
U64,
I8,
I16,
I32,
I64,
F32,
F64,
SEQ_ARGS,
ChDef,
Expand Down Expand Up @@ -1447,9 +1442,7 @@ def find_common_float_type(
if second_type == FLOAT:
return first_type
# both specific: wider wins
if max(first_type.bits, second_type.bits) > 32:
return F64
return F32
return first_type if first_type.bits >= second_type.bits else second_type

def find_common_integer_type(
self, first_type: FpyType, second_type: FpyType
Expand All @@ -1468,25 +1461,7 @@ def find_common_integer_type(
return None

# same signedness: wider wins
bits = max(first_type.bits, second_type.bits)
if first_unsigned:
if bits <= 8:
return U8
elif bits <= 16:
return U16
elif bits <= 32:
return U32
else:
return U64
else:
if bits <= 8:
return I8
elif bits <= 16:
return I16
elif bits <= 32:
return I32
else:
return I64
return first_type if first_type.bits >= second_type.bits else second_type

def _find_common_type_anon_struct(self, a: FpyType, b: FpyType) -> FpyType | None:
"""Return the concrete struct type if one side is an anonymous struct
Expand Down
Loading