Validate Fw.LogSeverity against the dictionary like the other canonical types (#225) - #238
Open
zimri-leisher wants to merge 1 commit into
Open
Validate Fw.LogSeverity against the dictionary like the other canonical types (#225)#238zimri-leisher wants to merge 1 commit into
zimri-leisher wants to merge 1 commit into
Conversation
…al types (#225) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225.
Every other canonical type the compiler bakes in (
Fw.CmdResponse,Fw.TimeComparison,Svc.BlockState, ...) goes through_validate_and_replace_type, butLOG_SEVERITYwas layered over thedictionary's definition unchecked. A dictionary defining
Fw.LogSeveritywithanother representation type would have
log()push a one-byte severity whilePOP_EVENTpopsFw::LogSeverity::SerialType, silently misreading the stack.It is registered
required=False, like the validity enums, so a dictionarywithout events still loads.
Red/green: the two new dictionaries (one widening the representation type to
U16, one renumbering
FATAL) load without complaint before the change andraise
DictionaryErrorafter; the third checks that removing the typealtogether still leaves the canonical definition standing.
🤖 Generated with Claude Code