Report a diagnostic when a non-finite float constant is cast to an integer (#229) - #237
Open
zimri-leisher wants to merge 1 commit into
Open
Report a diagnostic when a non-finite float constant is cast to an integer (#229)#237zimri-leisher wants to merge 1 commit into
zimri-leisher wants to merge 1 commit into
Conversation
…ant is cast to an integer (#229) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229.
const_convert_typecaught theValueErrorthatint()raises for NaN butnot the
OverflowErrorit raises for infinity, so casting an infinite constantto any integer type escaped as an uncaught Python exception in every position
that coerces the cast (assignments, command arguments, array indices, range
bounds,
exitandassertcodes). ListingOverflowErroralongsideValueErrorgives it the same diagnostic the NaN case already gets:For type F64: cannot convert float infinity to integer.Red/green: the two infinity sequences crash with
OverflowError: cannot convert float infinity to integerbefore the change and report a compile error after;the NaN sequence guards the branch that already worked. They reach infinity by
overflowing a float multiply/add rather than through an out-of-range literal, so
they stay valid independently of #110.
🤖 Generated with Claude Code