Report a domain error when const folding ** yields a complex number (#228) - #236
Merged
Merged
Conversation
…228) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228.
Const-folding
**calls Pythonfloat.__pow__, which returns a complex numberfor a negative base and a fractional exponent instead of raising. The folder
only expects int, float, Decimal or bool, so it died on
assert False, folded_valueinCalculateConstExprValues.visit_AstBinaryOp. The Decimal pathfor the same expression raises
decimal.InvalidOperationand is alreadyreported as
Domain error; this makes the float path agree.Red/green: the two new sequences (
F64(-8.0) ** 0.5and(-2.0) ** F64(0.5))crash the compiler with an
AssertionErrorbefore the change and reportDomain errorafter. The existing(-1) ** 0.5test covers the Decimal pathand passes throughout.
🤖 Generated with Claude Code