Skip to content

fprime-fpy-cmd sends commands that enclosing control flow would skip #230

Description

@zimri-leisher

fprime-fpy-cmd compiles the full source, extracts the sole ConstCmdDirective, and sends it without honoring the surrounding control flow (src/fpy/main.py:536–581). Consequently, the expression below would send CMD_NO_OP even though normal sequence execution skips it; this finding is based on source analysis, with no command transmitted. Reject anything other than a single bare command call with constant arguments before reaching the send path.

False and (CdhCore.cmdDisp.CMD_NO_OP() == Fw.CmdResponse.OK)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions