Skip to content

fix: BusClient.connect expects options object, not positional arg (#42) - #43

Merged
four-bytes-robby merged 1 commit into
mainfrom
fix/42-bus-connect-signature
Jun 17, 2026
Merged

fix: BusClient.connect expects options object, not positional arg (#42)#43
four-bytes-robby merged 1 commit into
mainfrom
fix/42-bus-connect-signature

Conversation

@four-bytes-robby

@four-bytes-robby four-bytes-robby commented Jun 17, 2026

Copy link
Copy Markdown
Member

Closes #42

Problem

TSC build failed with TS2559: BusClient.connect() API changed to accept { timeoutMs?: number } but call site still passed 3000 as positional argument.

Fix

Changed BusClient.connect(3000)BusClient.connect({ timeoutMs: 3000 }) in src/bus-publisher.ts:13.

Verification

  • bun run typecheck passes ✅

Summary by cubic

Fix TSC TS2559 by updating BusClient.connect(3000) to BusClient.connect({ timeoutMs: 3000 }) to match the new options-object signature.

Written for commit 5f71e0a. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Refactor
    • Updated internal connection timeout configuration.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

Recent review info
Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 40927576-9c9d-47c9-ae64-5bfaa97af49c

Commits

Reviewing files that changed from the base of the PR and between a6c171e and 5f71e0a.

Files selected for processing (1)
  • src/bus-publisher.ts

Walkthrough

Walkthrough

BusPublisher.init() in src/bus-publisher.ts updates a single call to BusClient.connect, replacing the positional numeric argument 3000 with an options object { timeoutMs: 3000 } to match the updated BusClient.connect API signature.

Changes

BusClient Connect Argument Fix

Layer / File(s) Summary
BusClient.connect options object src/bus-publisher.ts BusClient.connect(3000) is changed to BusClient.connect({ timeoutMs: 3000 }) on line 13 to align with the updated @four-bytes/opencode-plugin-lib API that accepts an options object instead of a positional number.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Finishing Touches
Generate docstrings
  • Create stacked PR
  • Commit on current branch
Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/42-bus-connect-signature
Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/42-bus-connect-signature

Comment @coderabbitai help to get the list of available commands and usage tips.

@four-bytes-robby
four-bytes-robby merged commit 9be25e3 into main Jun 17, 2026
3 of 4 checks passed
@four-bytes-robby
four-bytes-robby deleted the fix/42-bus-connect-signature branch June 17, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: BusClient.connect signature mismatch in bus-publisher.ts

1 participant