fix: BusClient.connect expects options object, not positional arg (#42) - #43
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Recent review infoRun configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Files selected for processing (1)
WalkthroughWalkthrough
ChangesBusClient Connect Argument Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Finishing TouchesGenerate docstrings
Generate unit tests (beta)
Simplify code
Comment |
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
Problem
TSC build failed with TS2559:
BusClient.connect()API changed to accept{ timeoutMs?: number }but call site still passed3000as positional argument.Fix
Changed
BusClient.connect(3000)→BusClient.connect({ timeoutMs: 3000 })insrc/bus-publisher.ts:13.Verification
bun run typecheckpasses ✅Summary by cubic
Fix TSC TS2559 by updating
BusClient.connect(3000)toBusClient.connect({ timeoutMs: 3000 })to match the new options-object signature.Written for commit 5f71e0a. Summary will update on new commits.
Summary by CodeRabbit