fix: subscribe to session-scoped channel - #40
Merged
Conversation
|
Caution Review failedThe pull request is closed. Recent review infoRun configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Files selected for processing (1)
WalkthroughWalkthrough
ChangesSession-scoped TUI subscription
Estimated code review effort2 (Simple) | ~5 minutes Possibly related issues
Finishing TouchesGenerate docstrings
Generate unit tests (beta)
Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
tbg/{sessionID}/statusinstead of wildcardtbg/+/statusto prevent cross-session token jumping.TokenMeterViewacceptssession_id: stringproptbg/${session_id}/status(session-scoped)sidebar_contentslot wiresprops.session_idthrough to the viewSummary by cubic
Scope the token meter subscription to the active session to prevent cross-session token updates. Subscribes to
tbg/${session_id}/statusinstead oftbg/+/status.TokenMeterViewacceptssession_idand uses it for the subscribe channel.sidebar_contentforwardsprops.session_idtoTokenMeterView.Written for commit 999fdaf. Summary will update on new commits.
Summary by CodeRabbit