fix: increase session TTL to 7 days - #39
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe default fallback value for the ChangesSession TTL Default Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents active sessions from being evicted after 1 hour. Closes the token counter reset bug.
Change
src/four-opencode-token-budget-guard.ts: defaultFOUR_TBG_SESSION_TTL_MSfrom60 * 60 * 1000(1 hour) to7 * 24 * 60 * 60 * 1000(7 days)SessionTokenCache, causing the token counter to reset mid-sessionWhy 7 days
FOUR_TBG_SESSION_TTL_MS) still available for shorter/longer valuesSummary by cubic
Increase the default session TTL from 1 hour to 7 days in
SessionTokenCacheto stop active-session eviction and token counter resets. Override viaFOUR_TBG_SESSION_TTL_MSis still supported; change is insrc/four-opencode-token-budget-guard.ts.Written for commit 46e07dc. Summary will update on new commits.
Summary by CodeRabbit
Chores