docs: add console logging rule — app().log only, console for startup only - #18
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 Recent review infoRun configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Files selected for processing (1)
WalkthroughWalkthrough
ChangesAGENTS.md updates
Estimated code review effort3 (Moderate) | ~15 minutes Possibly related issues
Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Tip: You can configure your own custom pre-merge checks in the settings. Finishing TouchesGenerate unit tests (beta)
Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added console logging convention to AGENTS.md.
Rule
Plugins MUST use
_client?.app?.log()for all logging in plugin mode —console.log/console.warn/console.erroris ONLY permitted for the initial startup"init"message. Console output in plugin mode breaks the terminal UI.Summary by cubic
Documented console logging rule: plugins must use
_client?.app?.log()in plugin mode;console.log/console.warn/console.errorare only allowed for the startup"init"message to avoid breaking the terminal UI.Also updated references to the central standards path to
~/ai-shared-rules/AGENTS.md.Written for commit 3968911. Summary will update on new commits.
Summary by CodeRabbit