docs: mark A7 gatekeeping as complete #87 - #88
Merged
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark A7 (Gatekeeping & Review Automation) as complete in ROADMAP.md.
Note: Branch protection config needs adjustment
The push rejection revealed that the required status check is named "completed" but the CI job is named
Build & Test. In Settings → Branches → main → Edit:completed(doesn't exist)Build & Test(the actual CI job name from ci.yml)Without this fix, no PR can merge because the required check can never pass.
Closes #87
Summary by cubic
Checks off all A7 (Gatekeeping & Review Automation) acceptance criteria in
ROADMAP.mdand sets A7 status to Done, linked to #87. Adds a CodeQL security analysis workflow for JS/TS on PRs and pushes tomain.completedfrom Required status checks.Build & Test(the CI job name).Written for commit d989296. Summary will update on new commits.