Skip to content

fix: move stride sampling test null bytes outside first/last scan windows #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
four-bytes-robby merged 2 commits into from
Jun 23, 2026
Merged

fix: move stride sampling test null bytes outside first/last scan windows #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f01777
fix: move stride sampling test null bytes outside first/last scan win…
four-bytes-robby Jun 23, 2026
9f35a5c
Merge branch 'main' into fix/stride-sampling-test-window
four-bytes-robby Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/ingest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,10 +836,12 @@ describe("isBinaryContent", () => {
const buf = new Uint8Array(size);
buf.fill(0x20); // printable spaces
// Insert null bytes at every 1024th position (stride-aligned: 1024 = 2×512)
for (let i = 1024; i < size; i += 1024) {
// Start at 8192 to place nulls outside the first 8KB thorough scan (0–8191)
// Stop before the last 8KB window to place nulls outside the final thorough scan
for (let i = 8192; i < size - 8192; i += 1024) {
buf[i] = 0;
}
// Stride sampling at position 1024 catches the first null byte
// Stride sampling at stride position 1024 catches the first null byte
expect(isBinaryContent(buf)).toBe(true);
});

Expand Down
Loading