Skip to content

fix: reset _busPromise on publish failure to allow reconnect - #146

Merged
four-bytes-robby merged 1 commit into
mainfrom
fix/bus-reconnect-issues
Jun 14, 2026
Merged

four-bytes-robby merged 1 commit into
mainfrom
fix/bus-reconnect-issues

Conversation

@four-bytes-robby

@four-bytes-robby four-bytes-robby commented Jun 14, 2026

Copy link
Copy Markdown
Member

Resets _busPromise to null on publish failure so next call retries instead of using cached failed promise.


Summary by cubic

Reset _busPromise to null on publish failure so the next write retries connection instead of using a cached failed promise. Prevents the bus from getting stuck after transient errors.

Written for commit 3ba7338. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 64302ae1-1305-4460-8638-9d5cf55bf8a0

Commits

Reviewing files that changed from the base of the PR and between 55d308c and 3ba7338.

Files selected for processing (1)
  • src/status.ts
Finishing Touches
Generate docstrings
  • Create stacked PR
  • Commit on current branch
Generate unit tests (beta)

✅ Unit Test PR creation complete.

  • Create PR with unit tests
  • Commit unit tests in branch fix/bus-reconnect-issues
Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/bus-reconnect-issues

Comment @coderabbitai help to get the list of available commands and usage tips.

@four-bytes-robby
four-bytes-robby merged commit cb15dc8 into main Jun 14, 2026
5 of 6 checks passed
@four-bytes-robby
four-bytes-robby deleted the fix/bus-reconnect-issues branch June 14, 2026 16:20
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.


Generating unit tests... This may take up to 20 minutes.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

✅ Created PR with unit tests: #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant