fix: reset _busPromise on publish failure to allow reconnect - #146
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Files selected for processing (1)
Finishing TouchesGenerate docstrings
Generate unit tests (beta)✅ Unit Test PR creation complete.
Simplify code
Comment |
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
✅ Created PR with unit tests: #147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resets _busPromise to null on publish failure so next call retries instead of using cached failed promise.
Summary by cubic
Reset
_busPromiseto null on publish failure so the next write retries connection instead of using a cached failed promise. Prevents the bus from getting stuck after transient errors.Written for commit 3ba7338. Summary will update on new commits.